Update postsrsd.c #117
Merged
Update postsrsd.c #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some OSes like e.g. the BSDs have the connection inherit O_NONBLOCK. The result does not prevent postsrsd from working at all, but causes a syslogged error for roughly every other connection from cleanup. Removing the flag is a NOP if it's not set, so this change doesn't require an OS-dependent ifdef.
|
Thank you for the pull request! |
jeredfloyd
pushed a commit
to jeredfloyd/postsrsd
that referenced
this pull request
May 4, 2022
* Update postsrsd.c Some OSes like e.g. the BSDs have the connection inherit O_NONBLOCK. The result does not prevent postsrsd from working at all, but causes a syslogged error for roughly every other connection from cleanup. Removing the flag is a NOP if it's not set, so this change doesn't require an OS-dependent ifdef. * Reformat source code Co-authored-by: Timo Röhling <timo@gaussglocke.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some OSes like e.g. the BSDs have the connection inherit O_NONBLOCK.
The result does not prevent postsrsd from working, but causes a syslogged error for roughly every other connection from cleanup.
Removing the flag is a NOP if it's not set, so this change doesn't require an OS-dependent ifdef.