-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the new release of FilePathsBase #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we accessing fields on AbstractFilePaths?
Sort of. All types should have at least have a field called |
Can you fill me in on why the use of |
It’s mostly a namespacing issue for generic names like root, drive and parts. Also, parts and segments have different behaviour now. The reason this changed is that getproperty can be used as a way of handling depreciations now. |
hmm, the namespacing use-case is interesting. Still not sure how I feel about this though. |
That's part of the reason we don't have a 1.0 release yet. I figured we should try the |
ok, I am down with exploring it and trying it out. This looks fine, fix CI before merging yes? |
@rofinn and @oxinabox could we tag and release a version here ASAP? Right now the whole released versions are broken because one gets the latest version of FilePathsBase, which removes functions like This is causing a major headache right now for a workshop that I have to teach tomorrow :) I'll also try to add the appropriate bounds to the registry now. |
Shouldn't FilePaths.jl be upperbounding FilePathsBase? Oh, damn, I forgot to tag a release after dropping the REQUIRE file. And the METADATA synching didn't place an upperbound. |
This depends on the new FilePathsBase version being released.