-
-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for linux/arm64 architecture #98
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 96.61% 96.61%
=======================================
Files 12 12
Lines 414 414
=======================================
Hits 400 400
Misses 9 9
Partials 5 5 Continue to review full report at Codecov.
|
V8 static library for ubuntu-latest/x64
V8 static library for ubuntu-latest/arm64
Thanks for the PR @abemedia |
Nice one @rogchap! Would you like me to add tests for Also, do you have any idea why this build for |
Hey @abemedia Code looks good. I've updated to fix the FOSSA issue. Looking at the build error for |
Hey @abemedia, Apologies, there has been a lot of work done for Windows static binary and upgrades to V8 that has added quite a few conflicts. |
Closing since #223 was merged |
This PR adds arm64 architecture (#97).
I was trying to also get armv7 to work but struggling so doing that as a separate PR (abemedia#1).
Edit: just realised my IDE reformatted your YAML.
Do you want me to revert old old formatting (i.e. 4 spaces indentation, not 2)?