STM32F4: Fix support of second I2C device (I2C2) and add a third (I2C3) #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current STM32F4 code, support for the second I2C channel is not fully written and works only on some controllers. Despite the fact that the variant files contains macros for setting I2C2 pins, it values are not used in the code and the I2C2 device is always created on the hard-coded pins PB10 PB11. Because of this, I2C2 does not work on boards where the I2C2 interface uses another pins.
This PR fixes these errors, and also adds support for the third (I2C3) channel.
Tested I2C1, I2C2 and I2C3 on the blackpil_F401 board.