fix definitions in the net package #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues: it was parsing all files regardless of tags, and one of the _solaris.go files in net imported a package which had all solaris tagged files, so no available files, so import failed. Also, the import name resolver needed a special case for C files. As a drive-by fix, we avoid a panic when trying to find the definition of an identifier that's derived from a tuple index assignment that has a type error.
rogpeppe
force-pushed
the
011-fix-net-definitions
branch
from
fcb80d4 to
61df203
Compare
This was referenced May 25, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues: it was parsing all files regardless
of tags, and one of the _solaris.go files in net imported
a package which had all solaris tagged files, so no
available files, so import failed.
Also, the import name resolver needed a special case
for C files.
Fixes issue #41.
As a drive-by fix, we avoid a panic when trying to find the
definition of an identifier that's derived from a tuple
index assignment that has a type error.