Use Styled Components as peer dependencies and do not bundle them #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Styled Components (along with React) were bundled in the final module bundle. This change addresses this by moving `styled-components` as a peer dependency and specifying it as an external module to Webpack. React and ReactDOM are also moved as external modules so that they are not present in the final bundle. Additional changes * Update Styled Components to the latest version * Remove `styled-theming` dependency as it was not used * Remove the `theme` default prop from components because it is being passed by the theme provider. * Add basic Prettier config with a one rule to use single quote for strings (same as in ESLint config).
|
Awesome, thanks for these changes. Published in 1.5.0. |
|
Great. Thanks for merging it and for the new version published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Styled Components (along with React) were bundled in the final module bundle. This change addresses
this by moving
styled-componentsas a peer dependency and specifying it as an external module to Webpack.React and ReactDOM are also moved as external modules so that they are not present in the final bundle.
Additional changes:
styled-themingdependency as it was not usedthemedefault prop from components because it is being passed by the theme provider.