Skip to content

Commit

Permalink
Shorten test name, correct comment about vtsql credential sequencing
Browse files Browse the repository at this point in the history
Signed-off-by: notfelineit <notfelineit@gmail.com>
  • Loading branch information
notfelineit committed Aug 31, 2023
1 parent 30e9983 commit ac3d2b3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion go/vt/vtadmin/vtsql/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ func (c *Config) Parse(args []string) error {

var username, password string

// If credentials-path-tmpl is provided, use those credentials instead
// First load credentials from credentials-path-tmpl, if provided
var tmplStrCreds *grpcclient.StaticAuthClientCreds
if *credentialsTmplStr != "" {
_creds, path, err := credentials.LoadFromTemplate(*credentialsTmplStr, c)
Expand Down
2 changes: 1 addition & 1 deletion go/vt/vtadmin/vtsql/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestConfigParse(t *testing.T) {
assert.Equal(t, expectedCreds, cfg.Credentials)
})

t.Run("it uses vtsql-credentials-password to override file password, if passed", func(t *testing.T) {
t.Run("uses vtsql-credentials-password", func(t *testing.T) {
t.Parallel()

f, err := os.CreateTemp("", "vtsql-config-test-testcluster-*") // testcluster is going to appear in the template
Expand Down

0 comments on commit ac3d2b3

Please sign in to comment.