model.Duration: disallow empty string (prometheus#247)

Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>

model/time.go

@@ -186,9 +186,12 @@ var durationRE = regexp.MustCompile("^(([0-9]+)y)?(([0-9]+)w)?(([0-9]+)d)?(([0-9
 // ParseDuration parses a string into a time.Duration, assuming that a year
 // always has 365d, a week always has 7d, and a day always has 24h.
 func ParseDuration(durationStr string) (Duration, error) {
-	// Allow 0 without a unit.
-	if durationStr == "0" {
+	switch durationStr {
+	case "0":
+		// Allow 0 without a unit.
 		return 0, nil
+	case "":
+		return 0, fmt.Errorf("empty duration string")
 	}
 	matches := durationRE.FindStringSubmatch(durationStr)
 	if matches == nil {

model/time_test.go

@@ -163,6 +163,8 @@ func TestParseBadDuration(t *testing.T) {
 		"1y1m1d",
 		"-1w",
 		"1.5d",
+		"d",
+		"",
 	}
 
 	for _, c := range cases {