Implement font attributes #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two opportunities for an error when reading a font: once for the font family, and again for the cached_face_id, so I think this error should tell which! It could well be a unit variant, but I'm erring on the side of specificity
|
I don't imagine there's any variation in the way Fonts are serialized. One test is probably enough. I won't stop you from adding more, but I don't think it's necessary. I'll give the code a once over in the morning but at a glance, please add this to the changelog 😉 |
Dekkonot
requested changes
Jun 28, 2023
Co-authored-by: Micah <dekkonot@rocketmail.com>
Co-authored-by: Micah <dekkonot@rocketmail.com>
Co-authored-by: Micah <dekkonot@rocketmail.com>
|
Commited from my iPhone |
Dekkonot
approved these changes
Jun 28, 2023
|
Merged from my Android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #290.
Should the folder-with-font-attribute test files have more & varied font attributes added? I sort of want to add more, but I think the spec is correct, and I'm not sure how important it is to test against more values here