-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RunContext does not work #667
Comments
In Rojo 7.2.1, this seems to be working for me: Main.server.lua paired with this Main.meta.json: {
"properties": {
"RunContext": "Client"
}
} |
Weird, I have Rojo 7.2.1 as well. I tried copy-pasting that meta file with files Some.server.lua and Some.meta.json, I got an unknown property error stopping me from starting Rojo at all: Using the explicit enum format doesn't error and appears in the Rojo tree (as shown before) but instead silently doesn't apply to my script, this is all really confusing. |
Fixed in |
When I created the issue, I had already updated it to 7.3.0, and it didn't work. (I stated that in the original issue, too) |
I updated to 7.3.0 and tried using the implicit format again as such: {
"properties": {
"RunContext": "Client"
}
} Same file names and setup as before, it no longer crashes like it did when I used 7.2.1, but still RunContext does not get applied: The issue persists and this was already mentioned at the bottom of this issue's description. :( |
@Zodanim @PoliceFighter761 |
Found out why this issue is only happening to some people: I had this issue when using the Roblox model version of the plugin, but switching to the plugin version managed by the VS Code extension fixed the issue. |
Hey @GammaWhiskey, does this happen with the plugin on GitHub releases? The one on Roblox.com? Both? |
Happens with the one on Roblox.com, not the plugin on GitHub releases |
Can confirm that this only happens on the toolbox plugin. After installing the plugin on the release page the RunContext gets properly synced. |
I got a chance to test the plugin on the GitHub releases page just now and can confirm the issue is gone, thanks everyone! I was letting the VS Code Rojo plugin manage the studio plugin for me, so it seems it installs the wrong version. |
@LPGhatguy Can you look into updating the Roblox plugin? This has caused a bunch of confusion, and makes it hard to want to make the switch to using RunContext when people will sync up your source code incorrectly. |
@ambergamefam LPG is no longer contributing to Rojo, so the existing plugin likely won't be updated. We have a new plugin located here that people should install and the documentation on Rojo's website has been updated to reflect that. I know that it's frustrating, and it's not the solution we would have liked, but it is what it is. To prevent this from ever becoming an issue again, the new plugin is published by a Roblox group rather than any one user, so if Boatbomber, me, or anyone else step away from Rojo it won't impact users again. That's unfortunately all we can do. |
Resolves #667 This PR: - Introduces a new field in the project file: `scriptType` which has the default value of `Class` (in parity with previous versions), but can also be `RunContext`. - This is then passed to `InstanceContext` from the `Project` struct. - This then changes the RunContext in the lua `snapshot_middleware` --------- Co-authored-by: Micah <dekkonot@rocketmail.com>
Resolves rojo-rbx#667 This PR: - Introduces a new field in the project file: `scriptType` which has the default value of `Class` (in parity with previous versions), but can also be `RunContext`. - This is then passed to `InstanceContext` from the `Project` struct. - This then changes the RunContext in the lua `snapshot_middleware` --------- Co-authored-by: Micah <dekkonot@rocketmail.com>
When specifying the RunContext property it simply does not get applied. Here is my setup:
with the following in the .meta
Which results in a Script with the RunContext set to legacy instead of Client:
In the mean time I have made a work-around extra plugin which applies the RunContext instead. It uses the following code:
which makes me believe that it can not be a permissions issue because the above code works.
Is there any way I can properly do this with rojo or do I have to wait for the time being? Am I doing something wrong?
I am using Rojo 7.3.0 but it did not work in the version prior either.
The text was updated successfully, but these errors were encountered: