Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ambiguous value resolution StringArray -> Tags #484

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Add ambiguous value resolution StringArray -> Tags #484

merged 2 commits into from
Oct 19, 2021

Conversation

kennethloeffler
Copy link
Member

@kennethloeffler kennethloeffler commented Sep 30, 2021

Closes #473. Depends on changes from rojo-rbx/rbx-dom#199.

This PR adds AmbiguousValue::StringArray so that Tags can be represented as an array of strings in our JSON format.

@kennethloeffler kennethloeffler marked this pull request as ready for review October 18, 2021 18:16
@LPGhatguy LPGhatguy merged commit 96112fe into rojo-rbx:master Oct 19, 2021
@kennethloeffler kennethloeffler deleted the tags-resolution branch October 19, 2021 22:13
Dekkonot pushed a commit to UpliftGames/rojo that referenced this pull request Jan 11, 2024
* Add ambiguous value resolution StringArray -> Tags

* Remove funny autocompleted reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rojo should be able to take CollectionService tags in the DOM and apply them to the game
2 participants