Fix Rojo breaking when users undo/redo in Studio #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
added
type: bug
…ort-undo-waypoints
chriscerie
reviewed
Jul 4, 2023
Co-authored-by: Chris Chang <51393127+chriscerie@users.noreply.github.com>
…r/rojo into support-undo-waypoints
Dekkonot
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #705.
After a patch is applied by Rojo, a ChangeHistoryService waypoint is created. This allows users to undo the patch without also undoing previous actions, as well as allowing them to undo later actions without accidentally wiping a patch as well.
Frankly, it's a bit shocking we haven't had more complaints about this.
In addition to fixing this bad behavior, I've added protection against accidental undos. Users are very unlikely to want to undo a Rojo patch, so we have this notification and warning to make sure it was intended.
Redoing or undoing further will dismiss the notification automatically as it is no longer relevant.