Better settings control #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
boatbomber
commented
Jul 9, 2023
boatbomber
commented
- Lock some settings during sync since they won't have effect if the session was already created
- This was done generically enough to support locking any setting for any reason in the future
- Make experimental features more clearly labelled using a flag prop that adds warnings instead of some desc text no one read
chriscerie
suggested changes
Jul 9, 2023
Co-authored-by: Chris Chang <51393127+chriscerie@users.noreply.github.com>
Dekkonot
approved these changes
Jul 12, 2023
Dekkonot
pushed a commit
to UpliftGames/rojo
that referenced
this pull request
Jan 11, 2024
- Lock some settings during sync - Make experimental features more clearly labelled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.