-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ambiguous syntax for Font properties #731
Conversation
The |
I don't think it's surprising necessarily, it's just rather inconvenient to have to specify a path to a JSON! Roblox offers |
bruh. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested building an rbxm from
{
"name": "TextBox",
"tree": {
"$className": "TextBox",
"$properties": {
"FontFace": {
"family": "rbxasset://fonts/families/RobotoMono.json",
"weight": "Thin",
"style": "Normal"
}
}
}
}
and was successful, lgtm
Given how unambiguous
Font
as a datatype actually is, it makes not very much sense to require people use the fully qualified syntax forFontFace
and any other properties that come up. So, this PR adds a new ambiguous syntax that supports it.Long-term, I think we should reconsider our strategy for font families to make it more obvious how to set them (maybe use an enum instead of a raw string?) but that's an issue for another day.