Confirmation behaviors #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boatbomber
added
type: enhancement
sasial-dev
reviewed
Aug 15, 2023
Dekkonot
requested changes
Aug 20, 2023
There was a problem hiding this comment.
Can we change what color the text for the input is? It's very difficult to read when it's hovered over right now.
EDIT: After looking at your initial post, I believe the text color is just actually wrong. When you fixed it in commit 011e24f, it looks like you reversed the order of the colors?
|
Whoops 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #773. Implements confirmation behavior setting.
For a given place, each project file being served will only confirm once in a given Studio session (This resolves the hot workflows of constant connect/disconnect, while still protecting against syncing a different project)
Always confirms before syncing (this is the current noisy behavior)
Only confirms when there are more than X changed instances, defined by the user
(Threshold setting is only shown while confirmation is set to Large Changes)
Only confirms when the project doesn't include the placeId in servePlaceIds
Due to the nature of the threshold setting, I also took the time to make our Setting component more versatile and robust. It can now handle any input component (checkbox, dropdown, custom button/textbox, plus the reset button) without worrying about desc text overlap.