Feature/watchos10 redesign #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidebar view and detail stationView
* add FavouritesSidebarView and FavouriteStation * add Favourites managed by SwiftData * added: find station by shortCode
WIP: more cleanup, is it good design to not pass in didSelect closure, but access modelContext?
* tweak previews
* add latestLocation to AppModel * extract Coordinator LocationDelegate * extract CoreLocation extension * refactor timer * don’t use didSet anymore for appState changes (to promptLocationAuth), use Combine and sink * don’t need appModel.isStationsModalPresented anymore (was to avoid that stationsModel getting closed when timer fired)
* add closest & closest other line station * select specific from green / red line * cleanup firing timer
(had issues with Xcode locking up)
* pending: how to toggle UI
* remove location from several states (TBD) * fix flow bugs when location not required * add more previews next up: * clean up formatting - centre multiple trains * add message in second screen
* fix logging of minutes * fix timer getting fired immediately after app start * fix getting 3 location updates which cause wasted API calls * fix .onChange deprecation warning * fix location flow
(still doesn’t work though?)
* tweak layout of line row (horizontal) * hide Map button (for now)
fix view pushes off station name: fornow, on one screen limit how many trains shown, cut off rest handle simple and doubleTimetable view differently
* extracted StationsModal
wrap previews in DEBUG to fix non-DEBUG build
not sure when I changed that??
WIP different resolutions - need more testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New architecture: NavigationSplitView
Refactor and Housekeeping