Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forgejo installs now have theme issues, lack theming #165

Open
adrinux opened this issue Jun 4, 2024 · 5 comments
Open

Forgejo installs now have theme issues, lack theming #165

adrinux opened this issue Jun 4, 2024 · 5 comments

Comments

@adrinux
Copy link
Contributor

adrinux commented Jun 4, 2024

I've been having issues with the theme on my Forgejo installs and have just figured out why.

(I note https://git.l3d.ch/ appears to show the same issue.)

I left the gitea_theme_default and gitea_themes undefined in my vars and just fell back onto the defaults defined by this role:

  gitea_theme_default: auto
  gitea_themes: auto,gitea,arc-green

But Forgejo no longer seems to provide gitea or arc-green themes in the default install and the default auto theme is now called forgejo-auto. There seems to be some theming if you leave everything as default but change the settings > appearance to one of those themes and there is now way to get back to a working theme (except presumably editing your account settings in the database..).

The solution was to define those two vars in my setup and rerun the role.

  gitea_theme_default: forgejo-auto
  gitea_themes: forgejo-auto

Then go to settings > appearance and set the theme to forgejo-auto.

Another fix that needs documenting? Also relevant to issue #147 I think.

@andrew-aiken
Copy link

The current default theme names are incorrect in the role. I switched them out the following and now it uses the default gitea themes.

gitea_theme_default: gitea-auto
gitea_themes: gitea-auto

https://docs.gitea.com/administration/customizing-gitea

@adrinux
Copy link
Contributor Author

adrinux commented Jun 5, 2024

Ah yes, and Forgejo still ships the Gitea themes as well as Forgejo variants, so that's a sensible fix. I can work up a pull request unless someone beats me too it...

The full list of Forgejo default themes, including several colourblind friendly variants can be found here.

@carranzamarioagustin
Copy link

I can reproduce the lack of theming on Gitea as well as Forgejo.

@adrinux
Copy link
Contributor Author

adrinux commented Jun 27, 2024

Untested as yet, but WIP using Jinja2 if statement to customize theme vars in my fork.

Edit: Well that was a stupid idea, but I now have a working attempt. Pull request on the way.

@adrinux
Copy link
Contributor Author

adrinux commented Jul 3, 2024

@carranzamarioagustin Can you test my suggested changes in Gitea? This Pull request works well with Forgejo but I have no testing setup for Gitea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants