-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue #165 missing themes #169
base: main
Are you sure you want to change the base?
Conversation
I personally ignore yamllint errors about line length. Has no effect on functionality and editors can wrap. Forgejo has a long list of themes. What can I do? I have no idea how to fix this in YAML and still leave it as a comma separated list of themes. Suggestions welcome. |
I see the custom yamllint in the project already sets it as a warning and 190 chars. Maybe the warning the action posts about an incompatible yamllint config causes the problem?
|
It seems ansible-lint treats all reports from yamllint as errors regardless of whether yamllint reports them as error or warning. Essentially ansible-lint is ignoring the yamllint config. I think the solution may be to add line-length to |
Added yamllint magic comments to ignore line-length for the forgejo themes var. Like so: gitea_theme_default: "forgejo-auto"
# yamllint disable rule:line-length
gitea_themes: "forgejo-auto,forgejo-light,forgejo-dark,gitea-auto,gitea-light,gitea-dark,forgejo-auto-deuteranopia-protanopia,forgejo-light-deuteranopia-protanopia,forgejo-dark-deuteranopia-protanopia,forgejo-auto-tritanopia,forgejo-light-tritanopia,forgejo-dark-tritanopia"
# yamllint enable rule:line-length As a workaround. Now passes the ansible-lint action check. |
This does the following:
It's been tested:
forgejo-auto
theme being used and fixed my original issue Forgejo installs now have theme issues, lack theming #165gitea_theme_default
toforgejo-dark
in my local host_vars worked as expected.I have not yet tested Gitea and will likely not have time for several weeks.