Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract fonts from js #517

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat: extract fonts from js #517

merged 1 commit into from
Oct 17, 2024

Conversation

teimurjan
Copy link
Contributor

@teimurjan teimurjan commented Oct 17, 2024

What's done

Changed font family setup

  • Removed injectFonts & injectFontsV2 functions to exclude fonts from the JS bundle.
  • Added separate fonts folder in the dist from where web & native projects will be able to import the fonts.

How to test

Tasks

  • Have you written tests for new code (if applicable)?
  • Have you tested the changes on all the platforms?
    • iOS
    • Android
    • Web
  • Have you added stories to demonstrate the new functionality (if there is any)?

Demo (screenshots, recordings, etc.)

@teimurjan teimurjan self-assigned this Oct 17, 2024
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: ac9f104

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@roll-network/design-system Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teimurjan teimurjan force-pushed the extract-fonts-from-js branch from 3863fb7 to ac9f104 Compare October 17, 2024 08:53
@teimurjan teimurjan merged commit 098961c into main Oct 17, 2024
1 check passed
@teimurjan teimurjan deleted the extract-fonts-from-js branch October 17, 2024 12:32
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants