Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64 slice excluded from cocoapods spec? #109

Closed
lavenj opened this issue Dec 3, 2021 · 5 comments · Fixed by #162
Closed

ARM64 slice excluded from cocoapods spec? #109

lavenj opened this issue Dec 3, 2021 · 5 comments · Fixed by #162
Assignees
Labels
cocoapods CocoaPods package manager related issues

Comments

@lavenj
Copy link

lavenj commented Dec 3, 2021

Hi! Looks like this library is still stripping the arm64 slice when building for the simulator, which causes issues when building for the simulator on an M1* mac.

Wondering if it would be possible to update the pod to include the required slice?

following podspec lines would need to be removed:

    s.pod_target_xcconfig  = { "ONLY_ACTIVE_ARCH" => "YES", "EXCLUDED_ARCHS[sdk=iphonesimulator*]" => "arm64" }
    s.user_target_xcconfig = { "ONLY_ACTIVE_ARCH" => "YES", "EXCLUDED_ARCHS[sdk=iphonesimulator*]" => "arm64" }

    s.tvos.pod_target_xcconfig  = { "ONLY_ACTIVE_ARCH" => "YES", "EXCLUDED_ARCHS[sdk=appletvsimulator*]" => "arm64" }
    s.tvos.user_target_xcconfig = { "ONLY_ACTIVE_ARCH" => "YES", "EXCLUDED_ARCHS[sdk=appletvsimulator*]" => "arm64" }

Background is here:

CocoaPods/CocoaPods#10978 (comment)
and
https://stackoverflow.com/questions/63607158/xcode-12-building-for-ios-simulator-but-linking-in-an-object-file-built-for-io/66233165#66233165

@akornich akornich self-assigned this Jan 18, 2022
@akornich akornich added the cocoapods CocoaPods package manager related issues label Feb 10, 2022
@keagan
Copy link

keagan commented Mar 31, 2022

curious where this is on the roadmap @akornich, as today is presumably the last day of 2022-Q1. thnx

@atetlaw
Copy link

atetlaw commented Apr 4, 2022

+1 for this, since the pod spec uses user_target_xcconfig it pollutes all the project configs through inheritance. I'm currently using post_install to read in every xcconfig and remove the line.

The guide mentions this and says its use is not recommended: https://guides.cocoapods.org/syntax/podspec.html#user_target_xcconfig

@jessesquires
Copy link

Another +1 — just want to share that this is also a problem for my projects.

@akornich
Copy link
Contributor

Guys, thanks for all the feedback. Let me see if I can squeeze it in within the next couple of weeks...

akornich added a commit to WideSpectrumComputing/rollbar-apple that referenced this issue Apr 20, 2022
@akornich akornich mentioned this issue Apr 20, 2022
12 tasks
@lavenj
Copy link
Author

lavenj commented Apr 25, 2022

Appreciated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cocoapods CocoaPods package manager related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants