Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Person information omitted in payloads for some use cases #119

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Person information omitted in payloads for some use cases #119

merged 5 commits into from
Feb 16, 2022

Conversation

akornich
Copy link
Contributor

Description of the change

Fix #110
Chore #118

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@akornich akornich added bug Something isn't working chore Something that does not directly affect product features, behavior or performance labels Feb 15, 2022
@akornich akornich requested a review from cyrusradfar February 15, 2022 22:51
@akornich akornich self-assigned this Feb 15, 2022
cyrusradfar
cyrusradfar approved these changes Feb 16, 2022
View reviewed changes
Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

In the future, if you're doing code cleanup -- please separate out the PRs so the functional work is separate.

@akornich akornich merged commit 3a9e72e into rollbar:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrusradfar cyrusradfar cyrusradfar approved these changes

Assignees

@akornich akornich

Labels
bug Something isn't working chore Something that does not directly affect product features, behavior or performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xcode autocomplete for Swift expects person.id, but codebase expects person.ID
2 participants
@akornich @cyrusradfar