Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old, non-working examples and low quality demos. #268

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Mar 16, 2023

Description of the change

The tvOS, watchOS and macOS Demos have been removed. The new Demo works on macOS and tvOS and there's nothing special that has to be done for watchOS.

None of the examples in Examples work, they're outdated and unmaintained and they don't really offer much help, nor do anything especially informative, so these have been removed also.

They were all laid out in a disorganized way and I've deemed they confuse more than they help. We want to make things as simple as possible for clients to get started with the Rollbar Apple SDK 3.0.0, and to make things as simple as they can be for our Customer Engineers and help desk.

We'll extend the current Demo and add specific examples as needed.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Mar 16, 2023
Copy link

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@matux matux merged commit 37a956c into master Mar 16, 2023
@matux matux deleted the remove_old_examples branch March 16, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants