Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podspec updates and code changes friendlier to Cocoapods #283

Merged
merged 11 commits into from
May 17, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented May 16, 2023

Description of the change

Since the last update of Xcode 14.3, support for iOS versions under 11.0 was dropped. This means that certain libraries aren't available to be linked when the minimum deployment version is set under 11.0.

This means that certain libraries whose podspec files are configured for a deployment target under 11.0 won't compile when using Cocoapods.

What makes matters worse is that there doesn't seem to be intent to fix this issue quickly: CocoaPods/CocoaPods#11895 (comment) since Cocoapods has been poorly maintained for quite a while.

This is the first set of changes that attempts to find a way around this problem.

This only affects Cocoapods, SPM and Carthage continue to work fine.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this May 16, 2023
@matux matux merged commit 1ce8f09 into feature/cocoapods May 17, 2023
@matux matux deleted the onepod branch May 17, 2023 16:02
@matux matux mentioned this pull request Jun 5, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants