Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import sqlite3 as a sys header to prevent conflicts with Flutter sqlite3 #290

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jun 5, 2023

Description of the change

Our Flutter SDK uses sqlite3 same as our Apple SDK. Flutter, however, requires platform-specific adapters for sqlite3 which means downloading certain libraries to get support: https://pub.dev/packages/sqlite3_flutter_libs.

Unfortunately, this will cause confusion when importing sqlite3. Since we need the system's header, we simply import sqlite3 as a system header and avoid looking into other header locations.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jun 5, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #122326: Excessive logging of Processing saved items.

Copy link
Contributor

@waltjones waltjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matux matux merged commit b971aa1 into master Jun 5, 2023
@matux matux deleted the fix_flutter branch June 5, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants