Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Package.swift include headers issues #304

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Fix Package.swift include headers issues #304

merged 4 commits into from
Jul 14, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 14, 2023 •
edited
Loading

Description of the change

This PR fixes include files not being found when running swift build.

It seems that, while an Xcode build would be successful, swift build wasn't passing include globs correctly to clang.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

  • Not tracked

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 14, 2023
ijsnow
ijsnow approved these changes Jul 14, 2023
View reviewed changes
Copy link

@ijsnow ijsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍠

@matux matux merged commit 700a6e7 into master Jul 14, 2023
@matux matux deleted the fix_ci branch July 14, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijsnow ijsnow ijsnow approved these changes

Assignees

@matux matux

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matux @ijsnow