Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix podspec not using RollbarCrash cpp sources #311

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 21, 2023

Description of the change

This PR fixes a problem in the RollbarCrash podspec that missed collecting .cpp source files. This also adds some environment compiler directives for Clang and instructs to link to the z and c++ sys libs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 21, 2023
@matux matux requested review from mudetroit and ijsnow July 21, 2023 00:08
@matux matux merged commit 4cc2699 into master Jul 21, 2023
@matux matux deleted the pod_add_cpp_src branch July 21, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants