Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix archiving release issues when integrating through latest Cocoapods #329

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 2, 2023

Description of the change

This PR fixes an issue where Cocoapods would create an incorrect header map for RollbarReport consequently not being able to find some RollbarCrash specific headers, which would in turn break RollbarNotifier compilation.

This only happens during Archiving and specifically while integrating with the latest 1.12.x version of Cocoapods.

The changelog has been updated to reflect this change. Users that integrate the SDK through SPM (the majority) don't need to update.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Aug 2, 2023
@matux matux merged commit 811acc2 into master Aug 2, 2023
@matux matux deleted the upd_locks branch August 2, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants