Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed RollbarCrash interface to RollbarCrashHandler #330

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 2, 2023

Description of the change

When integrating the SDK as a Framework through SPM, Swift has trouble understanding the difference between the RollbarCrash module and RollbarCrash interface

This PR renames the main RollbarCrash interface from RollbarCrash to RollbarCrashHandler

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

When integrating the SDK as a Framework through SPM, Swift has trouble understanding the difference between the RollbarCrash module and RollbarCrash interface
@matux matux self-assigned this Aug 2, 2023
@matux matux merged commit 6601540 into master Aug 2, 2023
@matux matux deleted the rollbarcrash branch August 2, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants