Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed extra data not being sent in payload for custom Swift errors #338

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 8, 2024

Description of the change

When logging additional details to an error via the data param in the Apple SDK, additional details in the form of a [String: Any] Swift dictionary are not captured on any logs on the dashboard. We've had to resort to adding additional data to the context field. ref

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Feb 8, 2024
Copy link

This pull request has been linked to Shortcut Story #133507: Apple SDK not sending data parameter to Item..

@matux matux merged commit 8f22dec into master Feb 13, 2024
1 check passed
@matux matux deleted the matux/321-bug branch February 13, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants