Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed onError callback not being set on the Flutter framework #107

Merged
merged 2 commits into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rollbar_flutter/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.4.1

- Fixed the SDK not hooking properly to the Flutter framework `onError` callback.

## 1.4.0

- Updated the Rollbar Apple SDK used by this SDK to handle native-level errors and crashes to the latest 3.x version.
Expand Down
2 changes: 1 addition & 1 deletion rollbar_flutter/example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rollbar_flutter_example
description: Demonstrates how to use the rollbar_flutter plugin.
version: 1.4.0
version: 1.4.1

publish_to: 'none' # Remove this line if you wish to publish to pub.dev

Expand Down
2 changes: 1 addition & 1 deletion rollbar_flutter/ios/rollbar_flutter.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
#
Pod::Spec.new do |s|
s.name = 'rollbar_flutter'
s.version = '1.4.0'
s.version = '1.4.1'
s.summary = 'Connect your Flutter applications to Rollbar for error reporting.'
s.description = <<-DESC
Connect your Flutter applications to Rollbar for error reporting.
Expand Down
4 changes: 3 additions & 1 deletion rollbar_flutter/lib/src/rollbar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ class RollbarFlutter {
transformer: (_) => PlatformTransformer(),
));

FlutterError.onError ??= onError;
if (onError != null) {
FlutterError.onError = onError;
}

await _platform.initialize(config: config);
await appRunner();
Expand Down
2 changes: 1 addition & 1 deletion rollbar_flutter/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rollbar_flutter
description: Connect your Flutter applications to Rollbar for error reporting.
version: 1.4.0
version: 1.4.1
homepage: https://www.rollbar.com
documentation: https://docs.rollbar.com/docs/flutter#flutter
repository: https://github.com/rollbar/rollbar-flutter
Expand Down
Loading