Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Version 2.9.0 breaks Sidekiq support #422

Closed
phlipper opened this issue Apr 9, 2016 · 2 comments
Closed

[BUG] Version 2.9.0 breaks Sidekiq support #422

phlipper opened this issue Apr 9, 2016 · 2 comments

Comments

@phlipper
Copy link

phlipper commented Apr 9, 2016

The new middleware update introduced in #421 is broken. The chain variable is missing on line 46 of lib/rollbar/sidekiq.rb. This results in the following stack trace:

started with pid 25175
undefined local variable or method `chain' for main:Object
/.bundle/ruby/2.3.0/gems/rollbar-2.9.0/lib/rollbar/sidekiq.rb:46:in `block in <top (required)>'
/.bundle/ruby/2.3.0/gems/sidekiq-4.1.1/lib/sidekiq.rb:69:in `configure_server'
/.bundle/ruby/2.3.0/gems/rollbar-2.9.0/lib/rollbar/sidekiq.rb:40:in `<top (required)>'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `block in require'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:240:in `load_dependency'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
/.bundle/ruby/2.3.0/gems/rollbar-2.9.0/lib/rollbar.rb:880:in `require_hooks'
/.bundle/ruby/2.3.0/gems/rollbar-2.9.0/lib/rollbar.rb:863:in `prepare'
/.bundle/ruby/2.3.0/gems/rollbar-2.9.0/lib/rollbar.rb:833:in `configure'
/config/initializers/rollbar.rb:4:in `<top (required)>'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:268:in `load'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:268:in `block in load'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:240:in `load_dependency'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:268:in `load'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/engine.rb:652:in `block in load_config_initializer'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/notifications.rb:166:in `instrument'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/engine.rb:651:in `load_config_initializer'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/engine.rb:616:in `block (2 levels) in <class:Engine>'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/engine.rb:615:in `each'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/engine.rb:615:in `block in <class:Engine>'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/initializable.rb:30:in `instance_exec'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/initializable.rb:30:in `run'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/initializable.rb:55:in `block in run_initializers'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:228:in `block in tsort_each'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:422:in `block (2 levels) in each_strongly_connected_component_from'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:431:in `each_strongly_connected_component_from'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:421:in `block in each_strongly_connected_component_from'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/initializable.rb:44:in `each'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/initializable.rb:44:in `tsort_each_child'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:415:in `call'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:415:in `each_strongly_connected_component_from'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:349:in `block in each_strongly_connected_component'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in `each'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in `call'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:347:in `each_strongly_connected_component'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:226:in `tsort_each'
/.rubies/ruby-2.3.0/lib/ruby/2.3.0/tsort.rb:205:in `tsort_each'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/initializable.rb:54:in `run_initializers'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/application.rb:352:in `initialize!'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/railtie.rb:194:in `public_send'
/.bundle/ruby/2.3.0/gems/railties-4.2.6/lib/rails/railtie.rb:194:in `method_missing'
/config/environment.rb:8:in `<top (required)>'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `block in require'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:240:in `load_dependency'
/.bundle/ruby/2.3.0/gems/activesupport-4.2.6/lib/active_support/dependencies.rb:274:in `require'
/.bundle/ruby/2.3.0/gems/sidekiq-4.1.1/lib/sidekiq/cli.rb:233:in `boot_system'
/.bundle/ruby/2.3.0/gems/sidekiq-4.1.1/lib/sidekiq/cli.rb:49:in `run'
/.bundle/ruby/2.3.0/gems/sidekiq-4.1.1/bin/sidekiq:12:in `<top (required)>'
/.bundle/ruby/2.3.0/bin/sidekiq:23:in `load'
/.bundle/ruby/2.3.0/bin/sidekiq:23:in `<main>'
exited with code 1
sending SIGTERM to all processes
@phlipper phlipper mentioned this issue Apr 9, 2016
Merged
@jondeandres
Copy link
Contributor

@phlipper thanks a lot for the report, we're sorry for this bug.

We've release 2.9.1.

@phlipper
Copy link
Author

phlipper commented Apr 9, 2016

@jondeandres thank you very much!

@fschwahn fschwahn mentioned this issue May 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phlipper @jondeandres