Clean scope before every Sidekiq job execution #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondeandres
force-pushed
the
clean-sidekiq-scope
branch
from
6345e1c to
3400d2e
Compare
jondeandres
force-pushed
the
clean-sidekiq-scope
branch
from
3400d2e to
d35d2d1
Compare
| config.server_middleware do |chain| | ||
| chain.add Rollbar::Sidekiq | ||
| end | ||
| else | ||
| config.error_handlers << Proc.new do |e, context| | ||
| chain.add Rollbar::Sidekiq::ClearScope |
There was a problem hiding this comment.
Thanks @phlipper, I'll release a new version in few minutes. Sorry for this.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Sidekiq > 3.x we are using the error handlers for the error reporting while we use a middleware for Sidekiq < 3.x.
So, in order to clean the scope in both solutions, we add a middleware to do it for Sidekiq > 3.x and complete the existing middleware for Sidekiq < 3.x.