Dump payload when we are writing to file. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -517,7 +517,7 @@ def do_write_payload(payload) | |||
| @file = File.open(configuration.filepath, "a") | |||
| end | |||
|
|
|||
| @file.puts payload | |||
| @file.puts(dump_payload(payload)) | |||
There was a problem hiding this comment.
I kinda think that we should do this first, before opening the file, to make things simpler in case the dump fails. Thoughts?
There was a problem hiding this comment.
You are right @brianr, I've just changed it.
jondeandres
force-pushed
the
dump-payload-when-write-file
branch
from
69ce696 to
09f387c
Compare
|
@brianr tests are passing here, I think we can merge this and release a new version. |
brianr
added a commit
that referenced
this pull request
Jan 9, 2015
Dump payload when we are writing to file.
|
Released as 1.3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.