Reraise exceptions on Rollbar.process_payload_safely. #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will reraise exceptions in
Rolbar.process_payload_safely
so async queues can retry the job or, in general, handle an error report some way.At same time that exception is silenced so we don't generate infinite reports. This example is what we want to avoid:
and a exception is raised
Sidekiq can retry the job reporting the original exception
report a new exception.
We'll then push to Sidekiq queue indefinitely until the network failure is fixed.
Using Rollbar.silenced we avoid the above behavior but Sidekiq will have a chance to retry the original job.