Fix delayed_job crash reports. Fixes #291 #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondeandres
force-pushed
the
fix-delayed_job-reports
branch
from
4f2a82e to
53b520c
Compare
Since serialization is made by JSON, we crashed delayed job reports cause we were exploting the JSON & ActiveSupport bug. Now we get the job data from job.payload_object.as_json. I've added tests for this, testing two different scenarios: - method without arguments - method with arguments Delete delayed_jobs before each spec. Use job.as_json for delayed_job.
jondeandres
force-pushed
the
fix-delayed_job-reports
branch
from
53b520c to
3fb2536
Compare
|
lgtm |
jondeandres
added a commit
that referenced
this pull request
Sep 15, 2015
Fix delayed_job crash reports. Fixes #291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since serialization is made by JSON, we crashed delayed job reports
cause we were exploting the JSON & ActiveSupport bug. Now we get the job
data from job.payload_object.as_json.
I've added tests for this, testing two different scenarios: