Restore MultiJson and add custom option modules. Fix #303 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support JRuby it'd be better not force installing Oj since
it cannot be used in JRuby if C extensions are not enabled, and they are
not supported by default.
So, we add MultiJson again to the project. This will create more
different scenarios but since it could be the best option according to
previous paragraph.
We've added in this change support for custom options depending on the
loaded adapter in MultiJson. We can add more adapter options modules in
this way:
module Rollbar
module JSON
module AnyMultiJsonAdapterName
def self.options
{ # here comes the options we need for that adapter }
end
end
end
end
We have, for now, just the Oj module that will return the options we had
before this commit.
The specs run with Oj by default and it's the recommended adapter to use
with Rollbar.
|
Not a big fan of this PR but pragmatically it is 👍 to do |
jondeandres
force-pushed
the
restore-multi_json-and-custom-options
branch
3 times, most recently
from
dd30c02 to
9b9c14d
Compare
- Add a Ruby extension that will install Oj when the platform is not JRuby - Rollbar::JSON will force to use Oj if it's defined. If not it'll use the MultiJson.current_adapter In summary. We'll use Oj for platforms != JRuby and any other one for JRuby.
jondeandres
force-pushed
the
restore-multi_json-and-custom-options
branch
from
9b9c14d to
e33f10e
Compare
added 2 commits
September 28, 2015 20:45
…-multi_json-and-custom-options
Closed
added 3 commits
September 30, 2015 13:58
And remove it from spec_helper
jondeandres
added a commit
that referenced
this pull request
Sep 30, 2015
…tions Restore MultiJson and add custom option modules. Fix #303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support JRuby it'd be better not force installing Oj since
it cannot be used in JRuby if C extensions are not enabled, and they are
not supported by default.
So, we add MultiJson again to the project. This will create more
different scenarios but since it could be the best option according to
previous paragraph.
We've added in this change support for custom options depending on the
loaded adapter in MultiJson. We can add more adapter options modules in
this way:
We have, for now, just the Oj module that will return the options we had
before this commit.