Make scrubbing length configurable #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rollbar.configuration.randomize_scrub_length = false` will make us using `'*' * value.length` as scrubbing value. When `randomize_scrub_length` option is true, by default, we use a random string between 3 and 8 chars.
jondeandres
force-pushed
the
scrubbing-length-behavior
branch
from
1f23832 to
638e97c
Compare
|
👍 |
jondeandres
force-pushed
the
scrubbing-length-behavior
branch
2 times, most recently
from
8466705 to
638e97c
Compare
jondeandres
added a commit
that referenced
this pull request
Oct 21, 2015
Make scrubbing length configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollbar.configuration.randomize_scrub_length = falsewill make ususing
'*' * value.lengthas scrubbing value.When
randomize_scrub_lengthoption is true, by default, we use arandom string between 3 and 8 chars.
Note: randomize code is duplicated in URL scrubber and the request extractor module. Once we refactor that module we can unify that logic.