Add plain ruby docs #374
Merged
Add plain ruby docs #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run_script ARGV | ||
|
|
||
| Rollbar.info "Script ran successfully" | ||
| rescue Exception => e |
There was a problem hiding this comment.
Since rescuing Exception is a bad practice, let's remove it.
You can do just rescue => e here.
There was a problem hiding this comment.
http://stackoverflow.com/a/10048406/456188
Better yet, let's rethrow afterward
|
@jondeandres Fixed |
| end | ||
|
|
||
| begin | ||
| Rollbar.debug "Running Script" |
There was a problem hiding this comment.
@Crisfole I think that conceptually we should left the the .debug() and .info() calls outside the begin/rescue block.
|
@jondeandres Should be good to go. |
| require 'rollbar' | ||
|
|
||
| Rollbar.configure do |config| | ||
| config.access_token = "SERVER_POST_ACCESS_TOKEN" |
There was a problem hiding this comment.
This should be "POST_SERVER_ITEM_ACCESS_TOKEN" to be consistent with the rest of this file (and work with the replacements that happen in our logged-in site)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document how to use Rollbar without Rack or Rails