Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced usage of exception filters in readme #477

Merged
merged 1 commit into from
Jun 3, 2016
Merged

Add advanced usage of exception filters in readme #477

merged 1 commit into from
Jun 3, 2016

Conversation

agrberg
Copy link
Contributor

@agrberg agrberg commented Jun 1, 2016

Callables can be passed as the values to handle errors differently
This is documented in the initializer at

# You can also specify a callable, which will be called with the exception instance.

@@ -501,6 +501,16 @@ This behavior applies to uncaught exceptions, not direct calls to `Rollbar.error
Rollbar.error(exception, :use_exception_level_filters => true)
```

### Advanced Usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Advanced usage" is sorta vague - how about a heading that describes what this does, maybe "Dynamic levels" ?

@brianr
Copy link
Member

brianr commented Jun 3, 2016

Thanks @agrberg!

@jondeandres can you review this to make sure this is accurate?

@jondeandres
Copy link
Contributor

@brianr sure, it's ok. I'll merge during the day. Thanks @agrberg!

@jondeandres jondeandres merged commit 0c4e33a into rollbar:master Jun 3, 2016
@agrberg
Copy link
Contributor Author

agrberg commented Jun 3, 2016

Happy to help. This feature is far too useful to not be in the docs.

@brianr I was asleep when you commented so I did not have a chance to change it before it was merged. I think your wording is better so I've updated it and added the missing link to the TOC in #481

@agrberg agrberg deleted the add_callable_exception_level_filter_to_readme branch June 3, 2016 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants