Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed doctoc tag #550

Merged
merged 1 commit into from
Dec 14, 2016
Merged

Removed doctoc tag #550

merged 1 commit into from
Dec 14, 2016

Conversation

jessewgibbs
Copy link
Contributor

It's causing issues in our GH pages submodule setup. Switching the page to use the same format as other notifiers.

It's causing issues in our GH pages submodule setup
@brianr
Copy link
Member

brianr commented Dec 14, 2016

The downside of this change is that it means the TOC will no longer be visible when viewing the readme inside GitHub. Are we ok with that?

As an alternative, maybe we could make all of the notifiers have the generated TOC in them (like this library did before this PR), and make whatever changes are needed so that it appears OK on rollbar.com/docs ?

@jessewgibbs jessewgibbs merged commit c28d23b into master Dec 14, 2016
@jessewgibbs jessewgibbs deleted the fix-toc branch December 14, 2016 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants