Send request body on DELETE request #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jondeandres
force-pushed
the
PUT-and-DELETE-params
branch
2 times, most recently
from
ff2beaa to
f620502
Compare
It seems that customers are sending body data in their DELETE request. In general those bodies are ignored by few servers but not always and not all of them. So, just allow DELETE requests to be body parseable.
jondeandres
force-pushed
the
PUT-and-DELETE-params
branch
from
f620502 to
0051ac2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that customers are sending body data in their DELETE
request. In general those bodies are ignored by few servers but not
always and not all of them.
So, just allow DELETE requests to be body parseable.