Add Rollbar::Middleware::Rack #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert `Rollbar::Middleware::Rack` to be a class instead of a module, so it can be added to the Rack middleware chain with `use Rollbar::Middleware::Rack`. Also, move the code from `Rollbar::Middleware::Sinatra` to `Rollbar::Middleware::Rack` since Sinatra behavior is a subset of Rack behavior.
jondeandres
force-pushed
the
rack-middleware
branch
2 times, most recently
from
0b547e1 to
f388fc5
Compare
|
|
||
| ```ruby | ||
| require 'rollbar/middleware/sinatra' | ||
| require 'rollbar/middleware/rack |
There was a problem hiding this comment.
missing an end '
jondeandres
force-pushed
the
rack-middleware
branch
from
4b5601a to
75c55d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
Rollbar::Middleware::Rackto be a class instead of a module,so it can be added to the Rack middleware chain with
use Rollbar::Middleware::Rack.Also, move the code from
Rollbar::Middleware::SinatratoRollbar::Middleware::Racksince Sinatra behavior is a subset of Rackbehavior.