Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host configuration option #560

Merged
merged 2 commits into from
Jan 3, 2017
Merged

Add host configuration option #560

merged 2 commits into from
Jan 3, 2017

Conversation

jondeandres
Copy link
Contributor

@jondeandres jondeandres commented Jan 2, 2017

Allows using a custom value for the host name. Usage:

Rollbar.configure do |config|
  config.host = 'my-custom-host'
end

Close #540

@jondeandres jondeandres changed the title Add host configuration option Add host configuration option Jan 2, 2017

**Default** unspecified

Allows using a custom host value instead the returned by `Socket.gethostname`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

### host

**Default** nil

The hostname (reported to Rollbar as `server.host`). When nil, the value of `Socket.gethostname` will be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Allows using a custom value for the host name. Usage:

```ruby
Rollbar.configure do |config|
  config.host = 'my-custom-host'
end

Close #540
@brianr
Copy link
Member

brianr commented Jan 2, 2017

👍

@jondeandres jondeandres merged commit 09d829b into master Jan 3, 2017
@jondeandres jondeandres deleted the custom-hostname branch January 3, 2017 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants