Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify delayed_job queue #574

Merged
merged 1 commit into from
Mar 8, 2017
Merged

specify delayed_job queue #574

merged 1 commit into from
Mar 8, 2017

Conversation

inquisitivus
Copy link
Contributor

Hi!
This is for my question in #563.

@rokob
Copy link
Contributor

rokob commented Mar 6, 2017

This will certainly break the existing behaviour where people assume jobs are run on the default delayed_job queue. It should be possible to add this feature, but doing it this way won't work.

@rokob
Copy link
Contributor

rokob commented Mar 6, 2017

One approach would be to add an option similar to https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/configuration.rb#L163 in the configuration for delayed_job here https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/configuration.rb#L148, and then if a queue is set on the delayed job class you can use that in the call method otherwise use the current default way of doing it.

@inquisitivus
Copy link
Contributor Author

I've changed my bits according to your advice. Is it ok now?

@rokob
Copy link
Contributor

rokob commented Mar 8, 2017

Looks good to me, thanks!

@rokob rokob merged commit b4b39db into rollbar:master Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants