Shoryuken gem support #576
Conversation
README.md
Outdated
| Read more about Shoryuken configuration @ https://github.com/phstc/shoryuken/wiki/Shoryuken-options | ||
|
|
||
| Also create the SQS channels equals to your environments, as follows: | ||
| The queues to report will be equal to ```rollbar_{CURRENT_ENVIROMNET}``` ex: if the project runs in staging environment the SQS to throw messages to will be equal to ```rollbar_staging``` |
There was a problem hiding this comment.
Small typo: CURRENT_ENVIROMNET -> CURRENT_ENVIRONMENT
README.md
Outdated
| ENV['AWS_SECRET_ACCESS_KEY'] = 'xxx' | ||
| ENV['AWS_REGION'] = 'xxx' | ||
| ``` | ||
| Read more about Shoryuken configuration @ https://github.com/phstc/shoryuken/wiki/Shoryuken-options |
There was a problem hiding this comment.
Could you make this a clickable link such as:
[here](https://github.com/phstc/shoryuken/wiki/Shoryuken-option)
lib/rollbar/delay/shoryuken.rb
Outdated
| rescue | ||
| # Raise the exception so Shoryuken can track the errored job | ||
| # and retry it | ||
| raise |
There was a problem hiding this comment.
@xbugster is this re-raise needed? Maybe it could be:
def perform(_sqs_message, payload)
Rollbar.process_from_async_handler(payload)
endAs the rescue is only re-raising it.
There was a problem hiding this comment.
removed rescue-rise. thnx.
|
Nice! This is for using Shoryuken as backend queue, not for error handling, like this, right? |
|
@xbugster looks like there are some failing tests in Travis. Can you take a look? |
|
@coryvirok @phstc 10q Cory, Fixed everything. climate & travis. |
|
Great! Thanks for cleaning things up. |
|
As a follow up feature-request (separate PR) would be a cool to have a Shoryuken plugin, like in |
|
Hi @coryvirok Any ETA for this? I would like to start using it without have to reference the git ref in the Gemfile. |
|
Our company would also like start using it out of the box. |
|
Everything LGTM |
No description provided.