-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Configuration#use_exception_level_filters option #588
Conversation
This seems fine to me. I guess the only question is whether you want this global configuration setting to be overridable on a per-call basis, i.e. if |
Hm I think I would expect that:
What if we do something like:
|
de34c84
to
76b0ff6
Compare
Let the users to set a global `use_exception_level_filters_default` option Usage: Rollbar.configure do |config| config.use_exception_level_filters_default = true end By default the setting is `false` so we keep the current interface Fix #587
76b0ff6
to
e3a890b
Compare
|
||
expect(Rollbar.last_report[:level]).to be_eql('warning') | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing a test when config.use_exception_level_filters_default = true
has been set, and when :use_exception_level_filters => false
is passed in with the Rollbar.error
call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one
b44bdbe
to
aa96d4f
Compare
I squashed those commits. |
Let the users to set a global
use_exception_level_filters
optionUsage:
By default the setting is
false
so we keep the current interfaceFix #587