Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support new sidekiq context structure #598

Merged
merged 4 commits into from
Jul 6, 2017

Conversation

itszootime
Copy link
Contributor

Hope I'm not causing any trouble by basically duplicating #549. However, I recognised that this pull request has gone stale. There's also a little bit more here:

  • A simpler implementation, not requiring the construction of two Gem::Version instances per error handled.
  • The specs now test with arguments the handler can expect to receive from Sidekiq.
  • An (extremely?) rare edge case where Sidekiq calls handle_exception with a nil context is now handled correctly.

It'd be great if we can get this merged as the sidekiq_threshold behaviour is currently completely broken when using Sidekiq >= 4.2.3. Cheers!

@itszootime itszootime force-pushed the support_new_sidekiq_context_structure branch from 3967a06 to 18c1b32 Compare June 9, 2017 09:34
@coryvirok
Copy link
Contributor

Thanks @itszootime! We will take a look soon.

@jkubacki
Copy link

@coryvirok could you take a look at it guys? We don't want another solution to go stale ;)

@rokob
Copy link
Contributor

rokob commented Jun 30, 2017

I'll take a look today

@rokob
Copy link
Contributor

rokob commented Jul 6, 2017

This looks good to me, merging it in

@rokob rokob merged commit b2b6f52 into rollbar:master Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants