Enhanced Sidekiq and SuckerPunch configuration #73
Conversation
… api Rollbar::Delay::Sidekiq now respond to #call which allows it to be bound to `Rollbar::Configuration#async_handler`. Cleans up Rollbar::Configuration api: use sidekiq by calling `#use_sidekiq(options)` instead of `#use_sidekiq=(options)`. Rollbar::Delay::Sidekiq specs are now isolated.
…ckerPunch to match previous async API changes. Added SuckerPunch spec
..around `Rollbar::Configuration#use_sidekiq=` and `Rollbar::Configuration#use_sucker_punch=` to match new syntax.
|
This looks great on first read. We'll need to provide migration instructions in the release notes, since anyone with config.use_sucker_punch = {
...
}in config/initializers/rollbar.com will need to update their code after upgrading. Will take a deeper look soon (possibly today, definitely within the next few days). |
|
@brianr I've added methods for old config directives to work as is, with deprecation warning. Spec with Ruby 1.8.7 are failing though, because of Sidekiq inclusion. |
|
@jeremyvdw very nice. Yes, I think that makes sense. Sidekiq isn't supported on ruby 1.8 anyway. |
|
One thing that would be cool is if there were tests for the deprecated setter methods. Otherwise looks good to me! |
Enhanced Sidekiq and SuckerPunch configuration
|
Awesome, thanks for the PR! |
|
Pushed to rubygems as version 0.12.0 |
This is a refactor exercice around
Rollbar::Configuration#use_sidekiq=andRollbar::Configuration#use_sucker_punch=methods which has led to a much better isolated classesRollbar::Delay::SidekiqandRollbar::Delay::SuckerPunch.Those classes instance variables responds to #call which allows to mock them for proc or lambda and behave like an ordinary
Rollbar::Configuration#async_handler.