Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status code to failed API send verbose log. #613

Closed
danielmorell opened this issue Mar 28, 2023 · 0 comments · Fixed by #614
Closed

Add status code to failed API send verbose log. #613

danielmorell opened this issue Mar 28, 2023 · 0 comments · Fixed by #614
Assignees
@danielmorell
Labels
Rank: 3 - Minor Tackle when there are no actionable Critical or Major requests. Status: 2 - Accepted The scope and characteristics of the request are defined and ready to be worked. Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Milestone
v3.2.0

Comments

@danielmorell
Copy link
Collaborator

When an occurrence send fails with an error status code, we should include the status code in the verbose log message.

rollbar-php/src/RollbarLogger.php

Lines 271 to 273 in d9a40c8

$this->verboseLogger()->error(
'Occurrence rejected by the API: ' . ($info['message'] ?? 'message not set')
);

This should also be backported to v3.
@danielmorell danielmorell added Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component. Status: 2 - Accepted The scope and characteristics of the request are defined and ready to be worked. Rank: 3 - Minor Tackle when there are no actionable Critical or Major requests. labels Mar 28, 2023
@danielmorell danielmorell added this to the v4.0.1 milestone Mar 28, 2023
@danielmorell danielmorell self-assigned this Mar 28, 2023
@danielmorell danielmorell modified the milestones: v4.0.1, v3.2.0 Apr 3, 2023
@danielmorell danielmorell closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@danielmorell danielmorell reopened this Apr 10, 2023
danielmorell added a commit that referenced this issue Apr 12, 2023
@danielmorell
Fixed #613 Added response status code to verbose log message.
820198c
This was referenced Apr 12, 2023
Merged
Merged
danielmorell added a commit that referenced this issue Apr 18, 2023
@danielmorell
Merge pull request #614 from rollbar/fixed/613-verbose-log-fail-status
8a8d63b 
Fixed #613 Added response status code to verbose log message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmorell danielmorell

Labels
Rank: 3 - Minor Tackle when there are no actionable Critical or Major requests. Status: 2 - Accepted The scope and characteristics of the request are defined and ready to be worked. Type: Enhancement Changes that add to, improve upon, enhance, or extend the existing component.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging a pull request may close this issue.

Fixed #613 Added response status code to verbose log message. rollbar/rollbar-php
1 participant
@danielmorell