Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psr/log 2 #536

Merged
merged 3 commits into from
Nov 5, 2021
Merged

Allow psr/log 2 #536

merged 3 commits into from
Nov 5, 2021

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Aug 2, 2021

Description of the change

This PR allows the installation of psr/log 2.0 and 3.0. It's possible to support all of those versions at once since the interfaces are used but not implemented anywhere.
Backporting is unnecessary since both 2.0 and 3.0 require PHP 8.

This PR is also a blocker for Seldaek/monolog#1564

More details are available in the new meta document: https://www.php-fig.org/psr/psr-3/meta/

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

nicolas-grekas
nicolas-grekas previously approved these changes Aug 20, 2021
Copy link

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(a quick merge would be appreciate as that creates some DX issues with new Symfony projects)

@bxsx
Copy link
Contributor

bxsx commented Oct 29, 2021

Hey @Jean85 and @nicolas-grekas.

It looks like our CI tests have failed. Does it work on your local machine?

@Jean85
Copy link
Contributor Author

Jean85 commented Oct 30, 2021

I made a mistake. The interface is used through the AbstractLogger, so you can't support 3.0 without adding the void return type to all the methods.
This would technically be a breaking change on your users, since they would have the same breakage you had in CI if they extended your classes without the void return types.

@bxsx
Copy link
Contributor

bxsx commented Nov 3, 2021

Thanks for the clarification, @Jean85

In the current situation, I can merge the current PR (for 2.0) and put 3.0 request to our internal backlog so we can update the code in the next major release.

@bxsx bxsx self-assigned this Nov 3, 2021
@Jean85
Copy link
Contributor Author

Jean85 commented Nov 4, 2021

Great! Thank you!

@bxsx bxsx changed the title Allow psr/log 2 & 3 Allow psr/log 2 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants