-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow psr/log 2 #536
Allow psr/log 2 #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a quick merge would be appreciate as that creates some DX issues with new Symfony projects)
Hey @Jean85 and @nicolas-grekas. It looks like our CI tests have failed. Does it work on your local machine? |
I made a mistake. The interface is used through the AbstractLogger, so you can't support 3.0 without adding the void return type to all the methods. |
Thanks for the clarification, @Jean85 In the current situation, I can merge the current PR (for 2.0) and put 3.0 request to our internal backlog so we can update the code in the next major release. |
Great! Thank you! |
Description of the change
This PR allows the installation of
psr/log
2.0 and 3.0. It's possible to support all of those versions at once since the interfaces are used but not implemented anywhere.Backporting is unnecessary since both 2.0 and 3.0 require PHP 8.
This PR is also a blocker for Seldaek/monolog#1564
More details are available in the new meta document: https://www.php-fig.org/psr/psr-3/meta/
Type of change
Development
Code review